Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DX-988] Fix text controller styles #515

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix: [DX-988] Fix text controller styles #515

merged 1 commit into from
Jan 18, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 16, 2024

Summary

The StyledInputController didn't update with the component, which led to OptimusDateInputField's text being displayed using the wrong style.

GIFs Before:

CleanShot 2024-01-16 at 14 34 16

After:

CleanShot 2024-01-16 at 14 33 15

Testing steps

  1. Open story with OptimusDateInputField
  2. Change the theme or disable/enable the component. The text style should be correct now.

Follow-up issues

I've noticed that the clean button would not change its color. I will double-check with the design team and will fix it in the follow-up if needed.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team January 16, 2024 13:41
@witwash witwash changed the title fix: Fix text controller styles fix: [DX-988] Fix text controller styles Jan 16, 2024
@witwash witwash enabled auto-merge (squash) January 16, 2024 14:38
@witwash witwash merged commit 2ff7279 into master Jan 18, 2024
8 checks passed
@witwash witwash deleted the DX-988 branch January 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants