Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: [DX-289] Migrate to token spacing #509

Merged
merged 3 commits into from
Jan 16, 2024
Merged

feat!: [DX-289] Migrate to token spacing #509

merged 3 commits into from
Jan 16, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 10, 2024

Summary

  • Replaced spacing values with one from tokens
  • [BREAKING CHANGE] Removed spacing constants that were exposed. You can access spacing values from the tokens now.

Testing steps

Just click through the stories a look if nothing looks off.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@github-actions GitHub Actions
Copy link
Contributor

⚠️ PR has more than 300 additions. Consider splitting it into smaller PRs.

@witwash witwash added the ignore-size Ignore the size of this PR label Jan 10, 2024
@witwash witwash marked this pull request as ready for review January 10, 2024 12:15
@witwash witwash requested a review from a team January 10, 2024 12:15
@witwash
Copy link
Contributor Author

witwash commented Jan 16, 2024

@ookami-kb, ping

@witwash witwash merged commit 421b480 into master Jan 16, 2024
6 checks passed
@witwash witwash deleted the DX-289 branch January 16, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb