Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DX-911] Fix disabled label style #506

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix: [DX-911] Fix disabled label style #506

merged 1 commit into from
Jan 5, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 5, 2024 •
edited
Loading

Summary

  • GroupWrapper now correctly supports disabled label style.
Preview Before:

CleanShot 2024-01-05 at 14 41 42

After:

CleanShot 2024-01-05 at 14 40 07

Testing steps

  • Open Checkbox/Radio group story.
  • Disabled group label should use textDisabled color and change its color depending on the style of the component.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review January 5, 2024 13:43
@witwash witwash requested a review from a team January 5, 2024 13:43
@witwash witwash merged commit 9881872 into master Jan 5, 2024
8 checks passed
@witwash witwash deleted the DX-911 branch January 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb