Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set to ignore local packages #491

Closed
wants to merge 3 commits into from
Closed

ci: Set to ignore local packages #491

wants to merge 3 commits into from

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Dec 7, 2023

Summary

Added mews_pedantic to ignore in storybook's dependabot. This will ensure dependabot will not switch mews_pedantic to pub version in its PRs.

Testing steps

Re-run dependabot and see if mews_pedantic dependency was changed.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team December 7, 2023 11:56
@witwash
Copy link
Contributor Author

witwash commented Dec 12, 2023

@ookami-kb,
what about this one? Otherwise, dependabot will update it to the pub version. See #489
CleanShot 2023-12-12 at 17 55 26

@witwash
Copy link
Contributor Author

witwash commented Dec 18, 2023

@ookami-kb, ping

@ookami-kb
Copy link
Contributor

But in pubspec.lock these dependencies are still "locked" to the specific version, no? Shouldn't they be updated?

@witwash
Copy link
Contributor Author

witwash commented Dec 23, 2023

@ookami-kb,
I'm a bit confused here. Yes, they are locked, but dependabot is changing it to the latest hosted one.
What I'm trying to do here is stop dependabot from changing pubspec.lock dependency that is pointing at the local package to the hosted one.

@ookami-kb
Copy link
Contributor

Let's discuss it in a call.

@witwash
Copy link
Contributor Author

witwash commented Dec 28, 2023

Closing as it is indeed a hosted dependency, thus this PR is not needed.

@witwash witwash closed this Dec 28, 2023
@ookami-kb ookami-kb deleted the dependabot-config branch December 28, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants