Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update .lock files in dependabot PRs #488

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Dec 6, 2023

Summary

Added a follow-up action to commit .lock files if PR was created by the dependabot.

Testing steps

Dependabot PR should trigger this action and changes in .lock should be committed.

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team December 6, 2023 16:27
@witwash
Copy link
Contributor Author

witwash commented Dec 7, 2023

@ookami-kb,
looks like dependabot is updated and this one is not needed anymore #489

@witwash witwash closed this Dec 7, 2023
@witwash witwash reopened this Dec 11, 2023
@witwash
Copy link
Contributor Author

witwash commented Dec 11, 2023

@ookami-kb, what do you think?

Copy link
Contributor

@ookami-kb ookami-kb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, yeah, makes sense, let's try it this way.

.github/workflows/dependabot-follow-up.yml Outdated Show resolved Hide resolved
@witwash witwash enabled auto-merge (squash) December 11, 2023 16:28
@witwash witwash requested a review from ookami-kb December 11, 2023 16:28
@witwash
Copy link
Contributor Author

witwash commented Dec 11, 2023

If this one is true,

When a Github Actions workflow is configured to run on pull requests, by default it will be triggered on three different types of activities: opened, synchronize, and reopened.

then by default, this action would be triggered on opened, reopened, and synchronize. But I could not find it in the docs and decided to define it explicitly.

@witwash witwash merged commit 438952e into master Dec 12, 2023
6 checks passed
@witwash witwash deleted the storybook-dependabot branch December 12, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants