Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix tokens action #478

Merged
merged 1 commit into from
Dec 4, 2023
Merged

ci: Fix tokens action #478

merged 1 commit into from
Dec 4, 2023

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Dec 4, 2023

Summary

  • updated trigger to act only on the last file. I'm planning to rewrite the action from the design-tokens, so it would not push after every commit. Then this trigger won't be needed.
  • updated gh pr command

Testing steps

Check if the action will trigger and run successfully.

Follow-up issues

Is there some action/cleanup needed after this PR is merged or deployed (e.g. consolidate some part outside the scope of this PR, etc)? Create issues for it with deadline and note them here and in the PR comments.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team December 4, 2023 12:42
@witwash witwash merged commit 817a664 into master Dec 4, 2023
6 checks passed
@witwash witwash deleted the fix-tokens-action branch December 4, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants