Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update generated files #476

Merged
merged 1 commit into from
Dec 1, 2023
Merged

refactor: Update generated files #476

merged 1 commit into from
Dec 1, 2023

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Nov 29, 2023

Summary

While working on the automatization I've noticed that some of our generated files are out of date due to the changes in freezed and mockito packages. Practically speaking nothing has changed.

Testing steps

None

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team November 29, 2023 16:34
@github-actions GitHub Actions
Copy link
Contributor

⚠️ PR has more than 300 additions. Consider splitting it into smaller PRs.

@ookami-kb ookami-kb changed the title chore: Update generated files refactor: Update generated files Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

⚠️ PR has more than 300 additions. Consider splitting it into smaller PRs.

@ookami-kb
Copy link
Contributor

I've changed type to refactor since it touches the code.

@witwash
Copy link
Contributor Author

witwash commented Nov 29, 2023

@ookami-kb,
OK, I wasn't sure, because it's a test file, generated test file

@witwash witwash merged commit b332653 into master Dec 1, 2023
7 checks passed
@witwash witwash deleted the update-generated-files branch December 1, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb