Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add namespace field to build.gradle #473

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

ooguz
Copy link
Contributor

@ooguz ooguz commented Nov 22, 2023

Summary

On Flutter 3.16, kiosk_mode package fails to build with the error message below:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':kiosk_mode'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Specify a namespace in the module's build file. See https://d.android.com/r/tools/upgrade-assistant/set-namespace for information about setting the namespace.

     If you've specified the package attribute in the source AndroidManifest.xml, you can use the AGP Upgrade Assistant to migrate to the namespace value in the build file. Refer to https://d.android.com/r/tools/upgrade-assistant/agp-upgrade-assistant for general information about using the AGP Upgrade Assistant.

That's why I added namespace field to build.gradle file.

Testing steps

Built.

Follow-up issues

Other packages on the repository may be updated as well.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@ooguz ooguz requested a review from a team November 22, 2023 12:33
@ookami-kb ookami-kb changed the title Add namespace field to build.gradle fix: Add namespace field to build.gradle Nov 28, 2023
@ookami-kb ookami-kb merged commit 6eccf4c into MewsSystems:master Nov 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants