Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-5791 Add documentation for reservations/getChannelManagerDetails end point #737

Merged
merged 14 commits into from
Feb 20, 2025
Merged

CON-5791 Add documentation for reservations/getChannelManagerDetails end point #737

merged 14 commits into from
Feb 20, 2025

Conversation

ShadiWa
Copy link
Contributor

@ShadiWa ShadiWa commented Feb 17, 2025

…end point

Summary

Checklist

  • Documentation follows the Style Guide
  • JSON examples updated
  • Properties in JSON examples are in the same order as in property tables
  • Changelog dated the day when PR merged
  • Changelog accurately describes all changes
  • Changelog highlights the affected endpoints or operations
  • Changelog highlights any deprecations
  • All hyperlinks tested
  • Deprecation Table updated if any deprecations
  • SUMMARY.md updated if new pages added

@ShadiWa ShadiWa self-assigned this Feb 17, 2025
@ShadiWa ShadiWa marked this pull request as ready for review February 18, 2025 08:39
@ShadiWa ShadiWa requested review from a team as code owners February 18, 2025 08:39
@ShadiWa ShadiWa added Documentation Generator Pull requests related to reference documentation generator con.connectivity labels Feb 18, 2025
MikeAdamsMews
MikeAdamsMews approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@MikeAdamsMews MikeAdamsMews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShadiWa, I have suggested making the name simpler. I think Get channel manager details is fine and a lot simpler to read and write. Also made a couple of other minor suggestions. I'm approving it on the assumption that you will update the descriptions. Thank you.

ShadiWa and others added 9 commits February 19, 2025 16:20
@ShadiWa ShadiWa merged commit 3796fa3 into master Feb 20, 2025
3 checks passed
@ShadiWa ShadiWa deleted the CON-5791-Add-documentation-for-reservations/getChannelManagerDetails-end-point branch February 20, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnv jnv jnv left review comments

@MikeAdamsMews MikeAdamsMews MikeAdamsMews approved these changes

@horczech horczech horczech approved these changes

@VBuben VBuben VBuben approved these changes

Assignees

@ShadiWa ShadiWa

Labels
con.connectivity Documentation Generator Pull requests related to reference documentation generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShadiWa @jnv @horczech @MikeAdamsMews @VBuben