-
Notifications
You must be signed in to change notification settings - Fork 581
Backend tasks - Ashleigh Adams #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ash-leigh
wants to merge
18
commits into
MewsSystems:master
Choose a base branch
from
ash-leigh:feature/exchange-rate-provider-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backend tasks - Ashleigh Adams #799
ash-leigh
wants to merge
18
commits into
MewsSystems:master
from
ash-leigh:feature/exchange-rate-provider-implementation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored service implementation use factory pattern and KeyedSerivces to return appropriate service for BaseCurrency - Made QuoteCurrencies explicitly optional - Added remaining unit test projects
…age to classes that do not contain logic
…te concerns Refactored tests to use FakeLogger instead of FakeItEasy to more easily verify through unit tests thats correct logging is in place
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a production-ready Exchange Rate Provider for the Czech National Bank (CNB), following clean architecture principles and industry best practices for maintainability, reliability, and scalability. To test and run the solution please see instructions in
READMEat route of projects repositoryKey Design Decisions
While there is a couple of official data sources I used CNB's official REST API with Swagger documentation
https://api.cnb.cz/cnbapi/swagger-ui.html#//exratesso that we could have confidence in the formal API contractStructured the solution into four distinct layers (Domain, Application, Infrastructure, API) with clear dependency flow and implemented CQRS for query handling.
Implemented
ExchangeRateServiceFactorywith service key routing for currency-specific providers.Integrated Polly with exponential backoff, and timeout policies for HTTP calls to CNB API.
Implemented multi-layer validation
Dockerfile and Scalar UI for interactive API documentation.
Engineering Best Practices
Directory.Build.propsandDirectory.Packages.props[ExcludeFromCodeCoverage]attribute to test project Program.cs files and other infrastructure code that doesn't require testing.Backlog
Features that would be good to implement next
Implement more intelligent caching strategy
At the moment data from CNB is cached every hour but given the banks documentation provides the time its exchange rates as usually declared (14:30 weekdays, excluding holidays) there is opportunity to ensure the cache does not go stale.
Return
ValidForfor ratesReturning the date at which the exchange rate is valid would be beneficial to consumers.