Filip - Mews backend developer task (.NET) #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BusinessLogic (Domain), Data (Infrastructure) and move and renamed main project to Console and moved it as a sub project. Also added Unit Tests for custom csv based parser.
…e logic. Also small rename of BusinessLogic class from updater to manager.
There was a problem hiding this comment.
Pull Request Overview
This PR implements a complete solution for the Mews backend developer task for Filip. It restructures the existing codebase into a multi-project architecture with proper separation of concerns, implements exchange rate fetching from CNB (Czech National Bank), and adds both API and web client interfaces.
Key changes:
- Restructured solution into separate projects: BusinessLogic, Data, Api, Console, Client, and UnitTests
- Implemented CNB exchange rate provider with CSV parsing using CsvHelper
- Added RESTful API with Swagger documentation and a web-based UI client
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| ExchangeRateUpdater.sln | Reorganized solution structure with multiple projects and solution folders |
| ExchangeRateUpdater.Data/ExchangeRateProvider.cs | Core implementation for fetching and parsing CNB exchange rates |
| ExchangeRateUpdater.Api/Controllers/ExchangeRatesController.cs | REST API controller for exchange rate queries |
| ExchangeRateUpdater.Console/Program.cs | Console application entry point with DI configuration |
| ExchangeRateUpdater.Client/wwwroot/index.html | Web UI for viewing exchange rates |
| ExchangeRateUpdater.BusinessLogic/Models/* | Moved models to proper namespace |
| ExchangeRateUpdater.UnitTests/ParserTests.cs | Unit tests for CSV parsing functionality |
| Various .csproj files | Project configurations targeting .NET 7.0 |
Comments suppressed due to low confidence (1)
jobs/Backend/Task/src/ExchangeRateUpdater.Console/Program.cs:1
- The Microsoft.AspNetCore namespace is imported but never used in this file. Remove this unused import.
using Microsoft.Extensions.DependencyInjection;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jobs/Backend/Task/src/ExchangeRateUpdater.Data/ExchangeRateProvider.cs
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/tests/ExchangeRateUpdater.UnitTests/ParserTests.cs
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/src/ExchangeRateUpdater.Api/Models/ExchangeRateViewModel.cs
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/src/ExchangeRateUpdater.Api/ExchangeRateUpdater.Api.csproj
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/src/ExchangeRateUpdater.Client/wwwroot/index.html
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/src/ExchangeRateUpdater.Client/wwwroot/index.html
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/src/ExchangeRateUpdater.Api/Controllers/ExchangeRatesController.cs
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/src/ExchangeRateUpdater.Data/ExchangeRateProvider.cs
Outdated
Show resolved
Hide resolved
jobs/Backend/Task/src/ExchangeRateUpdater.Data/ExchangeRateProvider.cs
Outdated
Show resolved
Hide resolved
…d exposed it to test project via assembly info. Removed some blank spaces in Client. Added the requested ConfigureAway(false) to prevent deadlock. Also made all exceptions more specific not using generic Exception ex anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello this is the initial implementation for the backend task.
Reorganized the structure in multiple projects in src/ and tests/ to be more clean and organized.
I also added a Client and Api for frontend/backend testing for completeness.
Edit: I will be solving comments on my ticket later today for completeness👍
Edit2: I have completed copilot PR review fixes.
Edit3: I have added a docs section and a README.MD that was missing from the project