Take Home Test Implementation #679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove legacy task files and restructure solution - Add detailed technical approach documentation - Update solution structure with src and tests folders - Ignore logs directory in .gitignore
Create dotnet-desktop.yml
…vice - Remove CurrencyValidator class and move validation logic to CurrencyIsoService - Add detailed logging in ExchangeRateService and ExchangeRateProvider - Update CNBRateParser to use ICurrencyIsoService for currency validation - Enhance test coverage for currency code validation
- Delete placeholder unit test file with no meaningful test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of the Take Home Test. The solution has been developed with a focus on meeting the provided requirements while adhering to best practices.
For additional details on the implementation and the decisions made during the development process, please refer to the DotNet.md file included in this repository.