Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Movie Search & Detail Views - NOEL #620

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

noelsummer
Copy link

  • after pulling the repo, make sure that you update the .env with API_URL (https://api.themoviedb.org/3) and API_KEY (it's the best practice not to leak key in version control system).
  • the app has 2 views (search page & detail view)
  • the URL is stateful with search query (which means that query is saved although you hard refresh the page)
  • implemented infinite scrolling
  • implemented list virtualization for the performance optimization
  • setup prettier so that you don't need to worry about styling
  • setup husky to lint & format & run tests before committing the changes
  • added sample tests (Button component and formateDate utility)
  • added local font files for performance optimization
  • updated favicon as Mews's one :-)
  • updated README.md (you can find setup guide and useful pnpm scripts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant