Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaks #737

Merged
merged 4 commits into from
May 18, 2024
Merged

Fix leaks #737

merged 4 commits into from
May 18, 2024

Conversation

Kiisu-Master
Copy link
Contributor

@Kiisu-Master Kiisu-Master commented May 15, 2024 •
edited
Loading

I need help with tracking down the last CanvasItem RID. I can't find it

@MewPurPur
Copy link
Owner

MewPurPur commented May 18, 2024 •
edited
Loading

Any reason this is still in draft?

@Kiisu-Master
Copy link
Contributor Author

Kiisu-Master commented May 18, 2024 •
edited
Loading

I haven't found the last leaked canvas item

It always leaks 1 which means it's something only created once in the program lifetime

@Kiisu-Master Kiisu-Master marked this pull request as ready for review May 18, 2024 13:59
@MewPurPur
Copy link
Owner

The last leaked CanvasItem can be found later.

@MewPurPur MewPurPur merged commit 2c8046e into MewPurPur:main May 18, 2024
2 checks passed
@MewPurPur
Copy link
Owner

Thanks!

MewPurPur pushed a commit that referenced this pull request Jun 1, 2024
@Kiisu-Master
Fix leaks (#737)
2088e86
MewPurPur pushed a commit that referenced this pull request Jun 1, 2024
@Kiisu-Master
Fix leaks (#737)
d333836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kiisu-Master @MewPurPur