Reference texture support #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added initial Implementation - Only .png files are supported - No Overlay Option - Only supports native file import (no web or built-in explorer support)
Qainguin
commented
May 11, 2024
src/GlobalSettings.gd
Outdated
There was a problem hiding this comment.
I don't like that I have to use a signal in GlobalSettings, it feels like I'm doing something wrong.
There was a problem hiding this comment.
IMO move it inside the Indications singleton instead.
But it's fine as it is. Just move out of draft when you feel ready.
There was a problem hiding this comment.
Ok. I think I'll go figure that out.
|
This is an excellent initial implementation. |
|
Thanks! Should I mark as ready to merge or wait? |
|
Mark as ready if you want me to review the current code. |
- Changed imported_reference signal to be in Indications and not GlobalSettings - Hides the button when using web (Web Functionality not yet implemented)
|
Alright, I moved the signal to Indications and I made it invisible on web as it is not supported yet. It should now be ready to merge. |
|
Thanks! |
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
* Initial Commit - Added initial Implementation - Only .png files are supported - No Overlay Option - Only supports native file import (no web or built-in explorer support) * Added support for non-native file dialog * Removed Placeholder Texture in ReferenceTexture * Added ability to overlay the reference image * Various Changes - Changed imported_reference signal to be in Indications and not GlobalSettings - Hides the button when using web (Web Functionality not yet implemented) * Fixed Merge Conflict * Hopefully Fixed Merge Conflict * Another Fix
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
* Initial Commit - Added initial Implementation - Only .png files are supported - No Overlay Option - Only supports native file import (no web or built-in explorer support) * Added support for non-native file dialog * Removed Placeholder Texture in ReferenceTexture * Added ability to overlay the reference image * Various Changes - Changed imported_reference signal to be in Indications and not GlobalSettings - Hides the button when using web (Web Functionality not yet implemented) * Fixed Merge Conflict * Hopefully Fixed Merge Conflict * Another Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Reference Image Button
Reference Popup
No Overlay
Overlay
