Arguable improvements to GoodFileDialog #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swarkin
reviewed
Apr 20, 2024
| else: | ||
| second_section.append(drive_path) | ||
| var drive_paths := first_section + second_section | ||
| print(drive_paths) |
|
I personally think system dirs should be listes alongside drive names, just like in blender. |
|
The |
Any way to detect that? |
|
Yes, DirAccess.open() can return null, which is also exactly the error that happened to me which I sent on the Discord earlier. |
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some right-click actions. Uses drives instead of system dirs for the panel on the left. Small improvements in other parts of the codebase.
I'm done with this widget now, it's more than good enough given GodSVG's current quality.