Add background color setting #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think so |
|
Is this ready for review? |
|
Check out #690. I think the proper implementation of this would be not as a setting, but rather as a field inside a popup that contains various things relating to the background. |
|
Nevermind my last comment. Just rebase this and it can be merged. |
|
Ok |
|
If i update translation files now it will add other not related strings |
|
That's fine, it doesn't matter when updates are done. |
Kiisu-Master
force-pushed
the
background_color
branch
from
f4f99a1
to
0d7c4fb
Compare
you just added merge conflicts |
|
Thanks! |
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
* Add background color setting * Update translation files --------- Co-authored-by: Mew Pur Pur <[email protected]>
MewPurPur
added a commit
that referenced
this pull request
Jun 1, 2024
* Add background color setting * Update translation files --------- Co-authored-by: Mew Pur Pur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Vovkiv something happened with the ukrainian translation?