Changes in preparation for global menu support #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
MewPurPur
pushed a commit
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes and additions to the way actions are done in GodSVG. Now basically all functionality found in the top buttons also have an input action associated with them. Many of these input actions do not have a key bound to them, but they could be bound in the future, either out of the box, or allowing users to bind them.
Aside from input actions, this PR also adds a few signals, adds a few public methods to change state normally only accessible through buttons, and makes a few style enhancements.
These changes are designed to allow support for global menu integration in the future. However, I decided to future-proof and use the new API available only in Godot 4.3 or later, thus why I am splitting this into 2 PRs. For this first PR, everything in here is compatible with Godot 4.2.x. For what the full global menu support will look like, check out this branch: https://github.com/aaronfranke/GodSVG/tree/global-menu