Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the fallback file dialog #641

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Improve the fallback file dialog #641

merged 1 commit into from
Apr 8, 2024

Conversation

MewPurPur
Copy link
Owner

@MewPurPur MewPurPur commented Apr 7, 2024

image

Adds a setting to use this file dialog (Off by default because why would you, it's a fallback)

This isn't finished. TODO:

  • A file named "" already exists. Saving will overwrite its contents!
  • Figure out sorting
  • Filename validation for Save actions
  • Implement proper display logic for PNG too.
  • Internationalization

@MewPurPur MewPurPur force-pushed the good-file-dialog branch 7 times, most recently from bd8df16 to 56b7c09 Compare April 8, 2024 23:16
@MewPurPur MewPurPur marked this pull request as ready for review April 8, 2024 23:33
@MewPurPur MewPurPur merged commit 9f8dd1f into main Apr 8, 2024
1 check passed
@MewPurPur MewPurPur deleted the good-file-dialog branch April 8, 2024 23:33
MewPurPur added a commit that referenced this pull request Jun 1, 2024
MewPurPur added a commit that referenced this pull request Jun 1, 2024
MewPurPur added a commit that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant