Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove React Dependencies from Packages #308

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Remove React Dependencies from Packages #308

merged 2 commits into from
Dec 27, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Dec 27, 2024 •
edited
Loading

Description

  • Removed react dependencies from react-based packages for peer deps in order to better support multiple versions of react.
  • Updated packages to next patch version

Related Issue

N/A

Motivation and Context

  • Explict react version dependencies was leading to conflicting react versions when used in react 18 app

How Has This Been Tested?

  • Local Testing
  • Deployed beta testing

Screenshots (if appropriate):

N/A

@jbouder
Remove react dependencies from comet extras and data viz for peer dep…
6d77d0f 
…s in order to better support multiple versions of react.
@jbouder jbouder added the dependencies Update to some dependency label Dec 27, 2024
@jbouder jbouder merged commit d7d23fa into main Dec 27, 2024
6 checks passed
@jbouder jbouder deleted the dep-fix branch December 27, 2024 20:08
@jbouder jbouder added the release Contains a new version for release. label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bapplejax bapplejax bapplejax approved these changes

Assignees
No one assigned
Labels
dependencies Update to some dependency release Contains a new version for release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbouder @bapplejax