Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toast component to extras #306

Merged
merged 7 commits into from
Dec 27, 2024
Merged

Add toast component to extras #306

merged 7 commits into from
Dec 27, 2024

Conversation

bapplejax
Copy link
Collaborator

Description

Adds toast component with storybook and testing.

Related Issue

https://metrostarsys.sharepoint.com/sites/FrontendDevCoP/Lists/Tasks/DispForm.aspx?ID=24&e=GkVxp1

Motivation and Context

Want to add a toast notification to the extras.

How Has This Been Tested?

Tests created and run locally.

Screenshots (if appropriate):

@bapplejax bapplejax self-assigned this Dec 20, 2024
@jbouder
Copy link
Collaborator

jbouder commented Dec 20, 2024

A couple of initial comments, based on some basic testing.

  1. I would suggest updating the stories to display the toast based on a button click, not automatically
  2. The toast should slide in from the right and stay aligned to the right side.
  3. Add a allowClose prop to the component which is true by default. And update so that you can toggle the close button as needed. See the Alert component for a reference.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor things please.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great, just need a few minor updates.

Copy link
Collaborator

@jbouder jbouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jbouder jbouder merged commit bb830ba into main Dec 27, 2024
6 checks passed
@jbouder jbouder deleted the add-toast-component-to-extras branch December 27, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants