chore: change TransactionService use in memory cache#53
Open
stanleyyconsensys wants to merge 1 commit intomainfrom
Open
chore: change TransactionService use in memory cache#53stanleyyconsensys wants to merge 1 commit intomainfrom
stanleyyconsensys wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Snap’s service wiring to use an in-memory cache for TransactionService instead of a state-backed cache, aligning its caching behavior with other services (e.g., PriceService) and avoiding writing transaction-related cache entries into persisted Snap state.
Changes:
- Replace
StateCachewithInMemoryCacheforTransactionServicecaching. - Remove the unused
StateCacheimport from the Snap context composition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
92
to
98
| const transactionService = new TransactionService({ | ||
| logger, | ||
| transactionRepository, | ||
| networkService, | ||
| transactionBuilder, | ||
| cache: new StateCache(state, logger, '__cache__transaction'), | ||
| cache: new InMemoryCache(noOpLogger), | ||
| }); |
wantedsystem
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the Snap’s service wiring to use an in-memory cache for TransactionService instead of a state-backed cache, aligning its caching behavior with other services (e.g., PriceService) and avoiding writing transaction-related cache entries into persisted Snap state.
the reason using memory cache is becoz state cache causing some issue on race condition
References
Checklist