fix: Clean up orphan messages during recovery #769
Merged
+101
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cleanupOrphanMessages store method to delete messages with seq < startSeq - Call cleanup during RemoteHandle recovery to prevent accumulation - Replace fake JSON test strings with simple placeholders Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
FUDCo
force-pushed
the
chip/cleanup-remote-tests
branch
from
cf44950 to
4319987
Compare
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
sirtimid
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup based on a close review of tests from my most recent PRs.
Note
Ensures crash recovery removes ACKed-but-not-deleted pending messages.
cleanupOrphanMessages(remoteId, startSeq)to storeremotemethods and export via kernel storecleanupOrphanMessagesfromRemoteHandle.#restorePersistedStateafter restoring seq state; log deletionsWritten by Cursor Bugbot for commit 4319987. This will update automatically on new commits. Configure here.