Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
f8e7b30 to
aecc753
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
aecc753 to
fa39370
Compare
fa39370 to
8eaea2f
Compare
8eaea2f to
9dc0a54
Compare
9dc0a54 to
c9db7bd
Compare
app/components/Views/confirmations/components/gas/gas-fee-token-modal/gas-fee-token-modal.tsx
Show resolved
Hide resolved
c9db7bd to
a3874f5
Compare
a3874f5 to
a8dded9
Compare
a8dded9 to
570461d
Compare
570461d to
053336a
Compare
053336a to
5da7f69
Compare
|
✅ E2E Fixture Validation — Schema is up to date |
5da7f69 to
fd2c804
Compare
|
b353c08 to
5f80de6
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| return {}; | ||
| } | ||
| return getTempoExtraOptionsForChain(chainId); | ||
| }; |
There was a problem hiding this comment.
Missing Tempo chain guard causes spurious warnings on all chains
Medium Severity
getChainExtraParamsForWalletSendCalls calls accountSupports7702 for every wallet_sendCalls on any chain and logs a misleading "Tempo chain but wallet does not support 7702" warning when the account doesn't support 7702, even on Ethereum mainnet. The equivalent logic in index.ts correctly gates on isTempoChain(chainId) before performing the 7702 check. This function is missing the same guard, causing unnecessary async overhead and noisy/misleading warnings for all non-7702 accounts on every chain.
5f80de6 to
fe8472e
Compare






Description
Meant to be used along with MetaMask/core#8052
Mobile twin of MetaMask/metamask-extension#40449
Changelog
CHANGELOG entry: adds Tempo transactions (partial) support on Mobile.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
High Risk
High risk because it changes transaction submission paths (
addTransaction,wallet_sendCalls) and fee-token selection/alerts using newexcludeNativeTokenForFeebehavior, which could affect signing, batching, and gas fee UX on supported chains.Overview
Adds Tempo chain (no native token) support by introducing
tempo-tx-utilsand routing Tempo transactions through a newaddTempoTransactionpath: non-Tempo-style txs get default fee-token options, while Tempotype: 0x76requests are validated and converted intoaddTransactionBatchcalls.Updates confirmations gas-fee UI and hooks to respect
excludeNativeTokenForFee: hides the native token option in the modal, disables the selector when there’s only one non-native choice, falls back to chain-configured fee token symbol/address when no native exists, and adjusts insufficient-balance messaging to display the configured symbol.Extends
BackgroundBridgeEIP-5792wallet_sendCallshandling to inject Tempo extra options when the account supports EIP-7702, adds Tempo chain IDs/symbol mapping, and bumps related controller dependencies; includes new/updated unit tests around Tempo utils and selection behavior.Written by Cursor Bugbot for commit 5f80de6. This will update automatically on new commits. Configure here.