chore(runway): cherry-pick fix(perps): cp-7.58.0 invalid tpsl behavior

[runway-github]

• fix(perps): cp-7.58.0 invalid tpsl behavior (fix(perps): cp-7.58.0 invalid tpsl behavior #21759)

Description

This PR fixes three issues with the TP/SL (Take Profit/Stop Loss)
functionality in the Perps trading feature:

1. TAT-1911: Fixed "Clear" button being unresponsive when keyboard
   is visible
2. TAT-1913: Fixed validation that prevented setting TP/SL between
   entry and current price for positions at a loss
3. Analytics Enhancement: Added missing properties (direction,
   source, position_size) to PERPS_RISK_MANAGEMENT MetaMetrics event

Key improvements:

• Keyboard now dismisses before clearing TP/SL values, ensuring button
  responsiveness
• Validation logic now uses current price (instead of entry price) as
  reference for existing positions, enabling TP/SL to be set between entry
  and current price when position is at a loss (still allows setting
  above/below current price as normal)
• Analytics events now include complete tracking data following the
  existing trackingData pattern to avoid duplicate API calls
• Refactored MetaMetrics tracking to build event properties once in
  finally block (similar to Sentry traces pattern)
• Extracted TPSLTrackingData type to eliminate type duplication across
  multiple files

Changelog

CHANGELOG entry: Fixed TP/SL Clear button responsiveness and validation
for positions at a loss

Related issues

Fixes:
TAT-1911,
TAT-1913

Manual testing steps

Feature: TP/SL Clear Button

  Scenario: user clears TP/SL with keyboard visible
    Given user is on TP/SL page
    And keyboard is visible from editing a TP/SL field

    When user taps "Clear" button
    Then keyboard dismisses
    And TP/SL values are cleared

Feature: TP/SL Validation for Positions at Loss

  Scenario: user sets TP/SL between entry and current price
    Given user has an open long BTC position
    And position is at -5% loss (current price below entry)

    When user navigates to Edit TP/SL
    And sets TP price between current price and entry price
    Then TP is accepted without validation error
    And TP order is successfully placed

Feature: Risk Management Analytics

  Scenario: user updates position TP/SL
    Given user has an open position

    When user updates TP/SL from position card
    Then PERPS_RISK_MANAGEMENT event includes direction, source, and position_size

Screenshots/Recordings

Before

• Clear button unresponsive when keyboard is up
• Validation error preventing TP/SL between entry and current price for
  losing positions
• Analytics missing key filtering properties

After

• Clear button dismisses keyboard and clears values
• TP/SL can be set between entry and current price
• Complete analytics data captured

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-10-28.at.16.31.27.mp4

Pre-merge author checklist

• I've followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format
  if applicable
• I've applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

---

Note

Dismisses keyboard before clearing TP/SL, validates TP/SL against current price for existing positions, and enriches PERPS_RISK_MANAGEMENT analytics with direction/source/position_size.

• UI (TP/SL View):
  • Dismiss keypad before clearing TP/SL via handleTakeProfitClear/handleStopLossClear; remove focus-based disable on Clear buttons in PerpsTPSLView.tsx.
  • onConfirm now passes trackingData {direction, source: 'tp_sl_view', positionSize}.
• Form Logic:
  • usePerpsTPSLForm: validate against current price for existing positions; use entry for new limit orders; memoized referencePrice/priceType.
• Controller & Analytics:
  • PerpsController.updatePositionTPSL: refactor to track one consolidated PERPS_RISK_MANAGEMENT event in finally with status, asset, completion_duration, source, optional direction, position_size, TP/SL prices, and error.
  • Add PerpsEventValues.SOURCE.TP_SL_VIEW and update event reference docs.
• Types & Navigation:
  • Introduce TPSLTrackingData; add trackingData to UpdatePositionTPSLParams and PerpsNavigationParamList.PerpsTPSL.onConfirm.
• Position Card & Update Hook:
  • Pass trackingData through PerpsPositionCard → usePerpsTPSLUpdate → controller.
• Tests:
  • Update and add tests for keyboard dismissal on Clear, onConfirm with trackingData, and new validation behavior.

^{Written by Cursor Bugbot for commit 251ffd4. This will update automatically on new commits. Configure here.}

---

Co-authored-by: Nick Gambino [email protected] d5f9885

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[Cal-L]

LGTM

[metamaskbot]

No release label on PR. Adding release label release-7.58.0 on PR, as PR was cherry-picked in branch 7.58.0.