-
-
Couldn't load subscription status.
- Fork 1.4k
test: remove cucumber and all dependencies #21829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit deletes several outdated feature files related to account actions, browser flow, confirmations, onboarding, performance, security, and wallet functionalities. Additionally, it removes unused step definitions and utility functions to streamline the codebase and improve maintainability. Changes include: - Deleted feature files for account actions, importing accounts, and various browser flows. - Removed step definitions that are no longer referenced in the tests. - Cleaned up the `generateTestReports.js` utility function. This cleanup helps reduce clutter and focuses on maintaining relevant test cases.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Warning MetaMask internal reviewing guidelines:
|
…mber removal This commit removes references to Cucumber in various configuration files and documentation, reflecting the transition to Detox for end-to-end testing. Key changes include: - Updated `.depcheckrc.yml` to remove unused Cucumber dependencies. - Modified `bitrise.yml` to remove Cucumber tag expressions and added notes for test filtering. - Updated README files to reflect the shift from Cucumber to Detox for end-to-end testing. - Adjusted WebdriverIO configuration files to remove Cucumber options and reporting functions. These changes streamline the testing setup and ensure clarity in the documentation regarding the current testing framework.
…k-mobile into remove-cucumber
|



Description
This commit deletes several outdated feature files related to account actions, browser flow, confirmations, onboarding, performance, security, and wallet functionalities. Additionally, it removes unused step definitions and utility functions to streamline the codebase and improve maintainability.
Changes include:
generateTestReports.jsutility function.This cleanup helps reduce clutter and focuses on maintaining relevant test cases.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Remove Cucumber-based E2E tests, configs, and dependencies, updating docs/CI and retaining Detox/Appium flows.
wdio/features/**,wdio/step-definitions/**, andwdio/utils/generateTestReports.js.wdio.conf.js; keepspec/junitreporters; clearspecs/suitesscaffolding.wdio/config/*.js) to dropcucumberOpts.tagExpression; keep capability selection via flags (--upgrade,--performance).CUCUMBER_TAG_EXPRESSIONusage/comments; keep WDIO BrowserStack runners and packaging of reports.@wdio/cucumber-framework, cucumber packages, gherkin prettier plugin, multiple-cucumber-html-reporter) and adjustlint-staged(drop*.feature).Written by Cursor Bugbot for commit 583a040. This will update automatically on new commits. Configure here.