Skip to content

Conversation

@chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Oct 28, 2025

Description

This commit deletes several outdated feature files related to account actions, browser flow, confirmations, onboarding, performance, security, and wallet functionalities. Additionally, it removes unused step definitions and utility functions to streamline the codebase and improve maintainability.

Changes include:

  • Deleted feature files for account actions, importing accounts, and various browser flows.
  • Removed step definitions that are no longer referenced in the tests.
  • Cleaned up the generateTestReports.js utility function.

This cleanup helps reduce clutter and focuses on maintaining relevant test cases.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: Remove cucumber test framework from mobile project
  Scenario: Mobile app behaves as expected after removing cucumber
    Given cucumber has been removed from repository
    When user uses mobile app
    Then mobile app behaves as expected

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Remove Cucumber-based E2E tests, configs, and dependencies, updating docs/CI and retaining Detox/Appium flows.

  • E2E/Testing:
    • Remove all Cucumber assets: delete wdio/features/**, wdio/step-definitions/**, and wdio/utils/generateTestReports.js.
    • Strip Cucumber config/hooks/reporters from wdio.conf.js; keep spec/junit reporters; clear specs/suites scaffolding.
    • Update BrowserStack/debug configs (wdio/config/*.js) to drop cucumberOpts.tagExpression; keep capability selection via flags (--upgrade, --performance).
  • CI (Bitrise):
    • Remove CUCUMBER_TAG_EXPRESSION usage/comments; keep WDIO BrowserStack runners and packaging of reports.
  • Docs:
    • Revise E2E docs to Detox/Jest only (remove Cucumber); Appium section trimmed; SampleFeature README now references Detox for E2E.
  • Deps/Tooling:
    • Remove Cucumber-related deps and reporters (@wdio/cucumber-framework, cucumber packages, gherkin prettier plugin, multiple-cucumber-html-reporter) and adjust lint-staged (drop *.feature).
    • Clean depcheck ignores to drop Cucumber items; yarn.lock pruned accordingly.

Written by Cursor Bugbot for commit 583a040. This will update automatically on new commits. Configure here.

This commit deletes several outdated feature files related to account actions, browser flow, confirmations, onboarding, performance, security, and wallet functionalities. Additionally, it removes unused step definitions and utility functions to streamline the codebase and improve maintainability.

Changes include:
- Deleted feature files for account actions, importing accounts, and various browser flows.
- Removed step definitions that are no longer referenced in the tests.
- Cleaned up the `generateTestReports.js` utility function.

This cleanup helps reduce clutter and focuses on maintaining relevant test cases.
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Oct 28, 2025
@socket-security
Copy link

socket-security bot commented Oct 28, 2025

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Warn Low
npm/@jridgewell/[email protected] is a AI-detected potential code anomaly.

Notes: The code implements a standard URL parsing and resolution utility with clear responsibilities and deterministic output for valid inputs. The primary security concern is lack of null-checks after regex.exec, which can cause runtime exceptions on malformed inputs. Otherwise, there is no evidence of malicious behavior. Recommended improvement is to guard regex results and validate inputs before accessing groups to prevent crashes and potential abuse.

Confidence: 1.00

Severity: 0.60

From: ?npm/[email protected]npm/[email protected]npm/[email protected]npm/[email protected]npm/@storybook/[email protected]npm/[email protected]npm/[email protected]npm/[email protected]npm/[email protected]npm/@babel/[email protected]npm/@react-native/[email protected]npm/@react-native/[email protected]npm/[email protected]npm/[email protected]npm/@babel/[email protected]npm/[email protected]npm/[email protected]npm/@jridgewell/[email protected]

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@jridgewell/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@chrisleewilcox chrisleewilcox changed the title test: remove deprecated feature files and clean up step definitions test: remove cucumber and all dependencies Oct 28, 2025
@chrisleewilcox chrisleewilcox marked this pull request as ready for review October 28, 2025 23:25
…mber removal

This commit removes references to Cucumber in various configuration files and documentation, reflecting the transition to Detox for end-to-end testing. Key changes include:

- Updated `.depcheckrc.yml` to remove unused Cucumber dependencies.
- Modified `bitrise.yml` to remove Cucumber tag expressions and added notes for test filtering.
- Updated README files to reflect the shift from Cucumber to Detox for end-to-end testing.
- Adjusted WebdriverIO configuration files to remove Cucumber options and reporting functions.

These changes streamline the testing setup and ensure clarity in the documentation regarding the current testing framework.
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner October 29, 2025 16:04
@chrisleewilcox chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Oct 29, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-XL team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants