-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore(predict): remove and change predict states #21827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one little thing that needs fixing, but otherwise looking good
a69e388 to
84b9c87
Compare
|



Description
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Replaces deposit tracking with per-account
pendingDeposits, removesclaimTransaction, and updates hooks/components/toasts/selectors and tests accordingly.claimTransaction; replacedepositTransactionwith per-provider/address mappendingDepositsand addclearPendingDeposit.depositWithConfirmationto managependingDepositsand validation; no claim state stored.usePredictDeposit: exposeisDepositPendingviaselectPredictPendingDepositByAddress; error handling unchanged.usePredictDepositToasts: clear viaclearPendingDeposit({ providerId }); supports provider param.usePredictToasts: makeclearTransactionoptional; guard calls.usePredictClaim: remove Redux status usage; keepclaimand error toast.usePredictClaimToasts: drop controller clearing; refresh positions on confirm.selectPredictPendingDepositsandselectPredictPendingDepositByAddress; remove deposit/claim transaction selectors.PredictBalanceandPredictPositionsHeader: useisDepositPendingto show “adding funds” and refresh balance when not pending.pendingDepositsand removed claim/deposit transactions.Written by Cursor Bugbot for commit 84b9c87. This will update automatically on new commits. Configure here.