Skip to content

Conversation

@georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Oct 28, 2025

Description

This PR fixes a bug that would not route users away from OnFido after submitting their KYC documents. It adds a case for SUBMITTED when polling for user's KYC data. Previously users were stuck on the onFido screen. Now they are correctly routed our verification page to be shown the loading, success or error cases.

This PR also updates .yarnrc.yml to add the ramp consensys packages to bypasses the npmMinimalAgeGate requirement that packages to be at least 3 days old before they can be installed.

Changelog

CHANGELOG entry: Fixed a bug that would not route users away from OnFido after submitting their KYC documents

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TRAM-2785

Manual testing steps

Feature: OnFido KYC redirection bugfix

  Scenario: user attempts to make a deposit order for $100+
    Given user has entered the standard KYC flow
    When user has uploaded all of their documents
    Then user is navigated away from onFido and shown our own processing page

Screenshots/Recordings

Before

Video showing user stuck on KYC modal after document submission:
https://www.loom.com/share/0ef683e7c7314136b6b48e9f2e1741e1

After

video showing the user being redirected after uploading documents:
https://www.loom.com/share/d67dfecd614f402a9ad48ae75cf132bd

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Route KYC status SUBMITTED to KycProcessing, add test coverage, bump @consensys/native-ramps-sdk to 2.1.6, and allow @consensys/* packages in Yarn age gate.

  • Deposit routing:
    • Handle KYC status SUBMITTED by navigating to KycProcessing in useDepositRouting.ts.
    • Add unit test for SUBMITTED flow in useDepositRouting.test.ts.
  • Dependencies:
    • Bump @consensys/native-ramps-sdk from 2.1.5 to 2.1.6.
  • Tooling/Config:
    • Allow @consensys/* in .yarnrc.yml npmPreapprovedPackages to bypass the minimal age gate.

Written by Cursor Bugbot for commit 2295fc5. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Oct 28, 2025
@socket-security
Copy link

socket-security bot commented Oct 29, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​consensys/​native-ramps-sdk@​2.1.5 ⏵ 2.1.69910010010080

View full report

@georgeweiler georgeweiler marked this pull request as ready for review October 29, 2025 16:24
@georgeweiler georgeweiler requested a review from a team as a code owner October 29, 2025 16:24
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the before/after videos.

@sonarqubecloud
Copy link

@georgeweiler georgeweiler added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 2f4bc08 Oct 29, 2025
93 checks passed
@georgeweiler georgeweiler deleted the fix/TRAM-2785/kyc-fix branch October 29, 2025 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-S team-ramp issues related to Ramp features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants