Skip to content

Conversation

@georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Oct 28, 2025

Description

This PR fixes a typo in the multichain balances hook where the property name was incorrectly spelled as isPortfolioVieEnabled instead of isPortfolioViewEnabled.

What is the reason for the change?
The property name isPortfolioVieEnabled contained a typo ("Vie" instead of "View"), which reduced code readability and could cause confusion for developers.

What is the improvement/solution?
Renamed the property to isPortfolioViewEnabled consistently across all files including:

  • TypeScript type definitions
  • Implementation in the useSelectedAccountMultichainBalances hook
  • All related unit tests

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

Feature: Portfolio view functionality

  Scenario: user views portfolio with multichain balances
    Given the app is running with portfolio view enabled
    
    When user navigates to account network info
    And user views their multichain balances
    Then the portfolio view displays correctly with no console errors or TypeScript errors

Screenshots/Recordings

N/A - This is an internal refactoring with no visual changes

Before

Property named isPortfolioVieEnabled (typo)

Screenshot 2025-10-28 at 11 29 59 AM

After

Property named isPortfolioViewEnabled (corrected)

Screenshot 2025-10-28 at 11 30 29 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Rename isPortfolioVieEnabled to isPortfolioViewEnabled across types, implementation, and tests.

  • Multichain Balances:
    • Rename isPortfolioVieEnabled -> isPortfolioViewEnabled in:
      • useMultichainBalances.types.ts interface MultichainBalancesData.
      • useSelectedAccountMultichainBalances.ts returned data.
  • Tests:
    • Update all references and expectations in:
      • useSelectedAccountMultichainBalances.test.ts.
      • account-network-info-expanded.test.tsx.

Written by Cursor Bugbot for commit 6db3cff. This will update automatically on new commits. Configure here.

@georgewrmarshall georgewrmarshall requested a review from a team as a code owner October 28, 2025 17:21
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Oct 28, 2025
@georgewrmarshall georgewrmarshall self-assigned this Oct 28, 2025
@georgewrmarshall georgewrmarshall added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Oct 28, 2025
@sonarqubecloud
Copy link

@georgewrmarshall georgewrmarshall changed the title chore: Fix typo in isPortfolioViewEnabled property name chore: fix typo in isPortfolioViewEnabled property name Oct 28, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 8173ef6 Oct 29, 2025
133 checks passed
@georgewrmarshall georgewrmarshall deleted the portfolio-view-rename branch October 29, 2025 08:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-XS team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants