Skip to content

Conversation

@vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Oct 28, 2025

Description

This is a collective effort to clean up our codebase by removing old feature flags such as PORTFOLIO_VIEW

Changelog

CHANGELOG entry:null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1132

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

~

Before

~

After

~

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes the PORTFOLIO_VIEW feature flag and related conditionals, making multi‑network/portfolio behavior the default across UI, selectors, polling, and tests, and cleans up env/CI config.

  • Feature flag removal:
    • Delete isPortfolioViewEnabled usage across components, hooks, selectors, and tests; default to portfolio/multi‑network behavior.
  • Behavioral simplifications:
    • Always set tokenNetworkFilter on network changes/additions.
    • Use multi‑chain swaps tokens and asset data by default (Asset, AssetDetails).
    • Poll across enabled EVM networks (or popular/all) based on GNS, removing portfolio checks (use*Polling hooks).
    • Simplify staking/earn views (unified logos; EarnTokenList gating only by lending flag).
  • Selectors/Utils:
    • Simplify getChainIdsToPoll; remove portfolio gating in earn/tokens selectors.
    • Multichain balance hook always reports portfolio mode.
  • Tests:
    • Remove mocks/branches for portfolio flag; update expectations for polling, token lists, snapshots, and flows.
  • Config Cleanup:
    • Remove PORTFOLIO_VIEW env from .js.env.example, Bitrise, and Jest config.

Written by Cursor Bugbot for commit 73769b7. This will update automatically on new commits. Configure here.

@vinnyhoward vinnyhoward requested review from a team as code owners October 28, 2025 17:12
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Oct 28, 2025
cursor[bot]

This comment was marked as outdated.

@vinnyhoward vinnyhoward requested review from a team as code owners October 28, 2025 20:57
@github-actions github-actions bot added size-L and removed size-M labels Oct 28, 2025
@vinnyhoward vinnyhoward requested review from a team as code owners October 29, 2025 16:49
@github-actions github-actions bot added size-XL and removed size-L labels Oct 29, 2025
@vinnyhoward vinnyhoward force-pushed the chore-mul-1132-portfolio-view-ff-removal branch from 7374481 to c81932d Compare October 29, 2025 17:20
@github-actions github-actions bot added size-L and removed size-XL labels Oct 29, 2025
cursor[bot]

This comment was marked as outdated.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 46.29630% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.91%. Comparing base (7d80805) to head (177ce9e).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/DetectedTokens/index.tsx 0.00% 12 Missing and 1 partial ⚠️
...mponents/Views/NetworkSelector/NetworkSelector.tsx 0.00% 5 Missing ⚠️
app/components/Nav/Main/index.js 0.00% 4 Missing ⚠️
app/components/Views/Wallet/index.tsx 84.61% 0 Missing and 2 partials ⚠️
...pp/components/hooks/useMultichainBalances/utils.ts 0.00% 2 Missing ⚠️
app/components/Views/AssetDetails/index.tsx 83.33% 0 Missing and 1 partial ⚠️
...Settings/NetworksSettings/NetworkSettings/index.js 75.00% 1 Missing ⚠️
...ponents/hooks/AssetPolling/use-polling-networks.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21806      +/-   ##
==========================================
- Coverage   77.26%   76.91%   -0.36%     
==========================================
  Files        3746     3768      +22     
  Lines       94220    95415    +1195     
  Branches    18110    18491     +381     
==========================================
+ Hits        72798    73385     +587     
- Misses      16509    17028     +519     
- Partials     4913     5002      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants