Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Oct 28, 2025

Description

Replace all usages of dummy selector with actual Predict balance.

Update imported token details.

Fix delay when using percentage buttons.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #6127 #21749

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Replaces dummy Predict balance with usePredictBalance across confirmations, migrates token constants to rich objects, and updates CustomAmount UI and percentage logic (no debounce).

  • Predict balance & alerts:
    • Replace dummy selector usages with usePredictBalance in useInsufficientPredictBalanceAlert and useTransactionCustomAmount (and related tests), removing predict-temp.
  • Token constants & add-token:
    • Consolidate to objects ARBITRUM_USDC and POLYGON_USDCE with address/decimals/name/symbol and update imports/usages (including useTokenFiatRates, TransactionDetailsStatus).
    • Extend useAddToken to include name; update PerpsDepositInfo/PredictDepositInfo and tests.
  • Custom amount UI/behavior:
    • Switch CustomAmount from inputs to static Text display; tweak styles (alignItems, lineHeight) and tests.
    • updatePendingAmountPercentage sets amountFiat directly to remove debounce delay.
  • Tests & cleanup:
    • Update/adjust affected tests; remove Blockaid banner test; minor mocks cleanup.

Written by Cursor Bugbot for commit 7f1319e. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Oct 28, 2025
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review October 28, 2025 21:25
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner October 28, 2025 21:25
@matthewwalsh0 matthewwalsh0 force-pushed the fix/predict-balance-usage branch from c2949ce to 7f1319e Compare October 29, 2025 10:10
@sonarqubecloud
Copy link

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 575641c Oct 29, 2025
87 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/predict-balance-usage branch October 29, 2025 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-M team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants