ci: enhance format check to block unformatted code in PRs #21801
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update format:check:changed to check all files in PR (origin/main...HEAD) instead of just last commit (HEAD~1) - Add format:check script for checking all files - Update CI workflow to fetch full git history and main branch for proper comparison - Ensures unformatted code is caught and blocks PR merges
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sethkfman
commented
Oct 28, 2025
jake-perkins
previously approved these changes
Oct 28, 2025
sallem-consensys
previously approved these changes
Oct 28, 2025
gambinish
previously approved these changes
Oct 28, 2025
7 tasks
vinnyhoward
previously approved these changes
Oct 28, 2025
sethkfman
dismissed stale reviews from vinnyhoward, gambinish, sallem-consensys, and jake-perkins
via
225bb62
weitingsun
previously approved these changes
Oct 28, 2025
Resolves parser error for .feature files in format:check
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
weitingsun
previously approved these changes
Oct 28, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MarioAslau
previously approved these changes
Oct 28, 2025
|
MarioAslau
previously approved these changes
Oct 29, 2025
metamaskbot
added
the
release-7.59.0
|
Force-merge used because it was imperative to get this in before other PRs to prevent additional formatting errors on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the format checking in CI to properly block unformatted code from being merged.
Changes:
format:checkscript for checking all files on the branchWhy:
The previous implementation only checked files in the last commit, which could allow unformatted code in earlier commits of a PR to slip through. This change ensures all files in the PR are checked.
CHANGELOG entry: null
Related issues
N/A
Manual testing steps
This change affects CI behavior. To test:
format:check:changedjob fails if any file is unformattedScreenshots/Recordings
N/A - CI configuration change
Pre-merge author checklist
Pre-merge reviewer checklist
Note
CI now runs
yarn format:checkacross the repo;package.jsonformatting scripts updated to cover js/ts/tsx/json and add a full-repo check.format:check:changedwithformat:checkin.github/workflows/ci.ymlmatrix to enforce full-repo formatting checks.package.json):format:checkscript and use it in CI.format/format:checkglobs to**/*.{js,ts,tsx,json}.format:check:changedto match the same file set.Written by Cursor Bugbot for commit 599b525. This will update automatically on new commits. Configure here.