Hide rewards badge #37766
Open
Hide rewards badge #37766
+140
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Montoya
approved these changes
Nov 13, 2025
Collaborator
Builds ready [2f85d95]
UI Startup Metrics (1235 ± 80 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Montoya
requested changes
Nov 13, 2025
Contributor
Montoya
left a comment
Montoya
left a comment
There was a problem hiding this comment.
There is just one issue with this implementation.
After dismissing, upon opening the extension, the button appears briefly and then disappears. It should default to hidden and check if the user has dismissed before showing it, instead.
Contributor
post-dismiss.mov |
Collaborator
Builds ready [a7209b6]
UI Startup Metrics (1281 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
jbblanc
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://consensyssoftware.atlassian.net/browse/RWDS-793
Allow rewards badge to be hidden
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a closeable Rewards badge that persists hidden state and updates rendering logic to respect it.
RewardsBadge: supportsallowHideBadge; shows a close icon on hover; hides on click viasetRewardsBadgeHidden(true)and persistsREWARDS_BADGE_HIDDENto storage; minor structure/class tweaks.RewardsPointsBalance: readsREWARDS_BADGE_HIDDENfrom storage on mount; conditionally renders badge/skeleton based onrewardsBadgeHidden; adjusts onboarding "seen" handling viasetOnboardingModalRendered.rewardsBadgeHiddentoRewardsStatewith actionsetRewardsBadgeHiddenand selectorselectRewardsBadgeHidden; initializes totrue.REWARDS_BADGE_HIDDENconstant.setRewardsBadgeHidden,selectRewardsBadgeHidden).RewardsBadge.test: mocksuseDispatch; verifies rendering and image/error behavior.Written by Cursor Bugbot for commit a7209b6. This will update automatically on new commits. Configure here.