-
Notifications
You must be signed in to change notification settings - Fork 5.2k
poc: confirmation intents #34097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
matthewwalsh0
wants to merge
22
commits into
main
Choose a base branch
from
poc/intents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
poc: confirmation intents #34097
+2,071
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support atomic swap and intent via extra transactions.
Support approvals. Add gas fee row.
Override asset picker. Split components. Split hooks.
Rename intents-row to intents-section. Rename useIntentsData to useIntentsQuote. Add loader.
Support native source tokens. Split rows.
Add quote indicator icon. Add dynamic targets.
Support decimal input.
Combine targets on same token.
Fix target if no balance. Remove 7702 check.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
POC of "intents" support within a transaction confirmation.
This enables native or ERC-20 assets required by the transaction to be automatically obtained on approval, via integrated swaps and bridging.
Includes:
value
, gas fee, and token transferdata
.auxilaryFunds
capability in awallet_sendCalls
RPC request.See #6073 for associated core changes.
Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Hyperliquid.Bridge.mov
Hyperliquid.Atomic.Swap.mov
Pre-merge author checklist
Pre-merge reviewer checklist