Skip to content

chore: solana wallet snap integrate packages - #72

Draft
Battambang wants to merge 14 commits into
mainfrom
chore/solana-wallet-snap-integrate-packages
Draft

chore: solana wallet snap integrate packages#72
Battambang wants to merge 14 commits into
mainfrom
chore/solana-wallet-snap-integrate-packages

Conversation

@Battambang

Copy link
Copy Markdown
Contributor
  • Move @metamask/solana-wallet-snap from merged-packages/ into packages/ and register it as a Yarn workspace.
  • Align package fields and shared dependency ranges (concurrently, dotenv, @metamask/superstruct, bignumber.js) with bitcoin-/tron-wallet-snap and yarn constraints.
  • Refresh snap.manifest.json after rebuild (shasum, repository → internal-snaps, platformVersion).
    WIP: Phase C is incomplete — remaining constraint deps, allow-scripts, lint/suppressions, CODEOWNERS, root README package list, CI secrets, etc. will land in follow-up commits on this branch.

Place the snap under packages/ so Yarn workspaces can resolve it, and
update yarn.lock for the new workspace dependencies.
Match description, keywords, and test scripts to the monorepo
workspace constraints used by the other snaps.
Bump concurrently, dotenv, @metamask/superstruct, and bignumber.js to
match bitcoin-/tron-wallet-snap and clear yarn constraints mismatches.
Refresh snap.manifest.json after rebuild (shasum, repository, platformVersion).
@socket-security

socket-security Bot commented Jul 30, 2026

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Jul 30, 2026

Copy link
Copy Markdown

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
Network access: npm @solana/rpc-transport-http in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: ?npm/@solana/kit@2.1.0npm/@solana/rpc-transport-http@2.1.0

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@solana/rpc-transport-http@2.1.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Medium
Network access: npm @solana/rpc-transport-http in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: ?npm/@solana-name-service/sns-sdk-kit@0.9.0-betanpm/@solana/rpc-transport-http@2.3.0

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@solana/rpc-transport-http@2.3.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Medium
Network access: npm @types/express-serve-static-core in module http

Module: http

Location: Package overview

From: ?npm/@types/express@5.0.6npm/@types/express-serve-static-core@5.1.2

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@types/express-serve-static-core@5.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Medium
Network access: npm glob in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: ?npm/rimraf@6.1.3npm/glob@13.0.6

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/glob@13.0.6. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Low
Publisher changed: npm @solana-program/compute-budget is now published by solana-devs instead of lorisleiva

New Author: solana-devs

Previous Author: lorisleiva

From: packages/solana-wallet-snap/package.jsonnpm/@solana-program/compute-budget@0.7.0

ℹ Read more on: This package | This alert | What is new author?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@solana-program/compute-budget@0.7.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Low
Publisher changed: npm @solana-program/system is now published by solana-devs instead of lorisleiva

New Author: solana-devs

Previous Author: lorisleiva

From: packages/solana-wallet-snap/package.jsonnpm/@solana-program/system@0.7.0

ℹ Read more on: This package | This alert | What is new author?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@solana-program/system@0.7.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Potential code anomaly (AI signal): npm glob is 68.0% likely to have a medium risk anomaly

Notes: The Glob utilities implement a conventional and well-structured filesystem glob-walking mechanism with robust control flow (abort signals, backpressure) and safe output semantics. There is no evidence of malicious behavior, backdoors, or data exfiltration within this fragment. Risks mainly relate to how downstream consumers may handle emitted paths, not to the library itself.

Confidence: 0.68

Severity: 0.50

From: ?npm/rimraf@6.1.3npm/glob@13.0.6

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/glob@13.0.6. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@Battambang Battambang changed the title Chore/solana wallet snap integrate packages chore: solana wallet snap integrate packages Jul 30, 2026
Sync with Release/3.0.0 (#71) before continuing Phase C work.
Match bitcoin-/tron-wallet-snap exact ranges (11.1.1 and 2.0.0) so yarn
constraints version consistency passes for these deps.
Bump root @types/lodash to ^4.17.15 so yarn constraints version
consistency matches the Solana workspace declaration.
Align rimraf to ^6.0.1 across workspaces that declare it so yarn
constraints version consistency passes and installs a single v6.
Narrow @metamask/snaps-cli to ^8.3.0 so yarn constraints version
consistency matches bitcoin-/tron-/sample-snap (still resolves to 8.4.1).
Sync with bitcoin keyring v2 (#43) and regenerate yarn.lock after
resolving the lockfile conflict.
Bump snaps-cli, snaps-sdk, superstruct, keyring-api, and
keyring-snap-sdk declarations to match bitcoin-/tron-wallet-snap
after #43 (installed versions unchanged).
Align @metamask/key-tree to ^10.1.1 with bitcoin-/tron-wallet-snap so
yarn constraints pass.
Absorb existing Solana snap lint findings into eslint-suppressions.json,
and apply minor autofixes from eslint --fix.
Assign @MetaMask/networks as owners for packages/solana-wallet-snap,
matching bitcoin- and tron-wallet-snap.
Update the generated packages section so readme-content:check passes
with the new workspace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant