Skip to content

chore: Expose missing AssetsController methods through the messenger#8719

Merged
GuillaumeRx merged 3 commits intomainfrom
gr/expose-assets-controller-methods
May 6, 2026
Merged

chore: Expose missing AssetsController methods through the messenger#8719
GuillaumeRx merged 3 commits intomainfrom
gr/expose-assets-controller-methods

Conversation

@GuillaumeRx
Copy link
Copy Markdown
Contributor

@GuillaumeRx GuillaumeRx commented May 6, 2026

Explanation

This exposes missing methods used in the clients through the messenger.

References

Progresses https://consensyssoftware.atlassian.net/browse/WPC-989

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: this only expands the messenger-exposed API surface to include an existing setSelectedCurrency method, with no changes to business logic or data handling.

Overview
Exposes AssetsController.setSelectedCurrency via the messenger. This adds the AssetsController:setSelectedCurrency action type, includes setSelectedCurrency in the controller’s MESSENGER_EXPOSED_METHODS, exports the new action type from index.ts, and unregisters the handler on destroy().

Updates the @metamask/assets-controller changelog to document the newly exposed action.

Reviewed by Cursor Bugbot for commit 8ae3b43. Bugbot is set up for automated code reviews on this repo. Configure here.

@GuillaumeRx GuillaumeRx marked this pull request as ready for review May 6, 2026 09:54
@GuillaumeRx GuillaumeRx requested review from a team as code owners May 6, 2026 09:54
@GuillaumeRx GuillaumeRx enabled auto-merge May 6, 2026 09:57
@GuillaumeRx GuillaumeRx force-pushed the gr/expose-assets-controller-methods branch from 8839121 to 9e2b67f Compare May 6, 2026 10:07
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9e2b67f. Configure here.

Comment thread packages/assets-controller/src/AssetsController.ts
@GuillaumeRx GuillaumeRx added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit e354b0b May 6, 2026
366 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/expose-assets-controller-methods branch May 6, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants