Conversation
SnapPlatformWatcher in service + add :ensureReadySnapPlatformWatcher in SnapAccountService + add :ensureReady and use it in MultichainAccountService
…vice + remove SnapPlatformWatcher
f7ccad3 to
aaaf1d3
Compare
hmalik88
previously approved these changes
May 6, 2026
hmalik88
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Now that we have a central place for Snap accounts logic, we can move the
SnapPlatformWatcherso we can use it (with an action) on theMultichainAccountService.Also adding a new
:ensureReady(snapId)action that will be improved in the future to make sure everything is ready when interacting with an account management Snap (migration, platform is ready, keyring is ready, etc...)References
N/A
Checklist
Note
Medium Risk
Introduces breaking messenger/API changes around Snap readiness (new required
SnapAccountService:ensureReady, removedMultichainAccountService:ensureCanUseSnapPlatform), which can break consumers and affect Snap-based account operations if integration is incomplete.Overview
Moves Snap platform readiness checks out of
@metamask/multichain-account-serviceand into@metamask/snap-account-service.SnapAccountServicenow ownsSnapPlatformWatcher, adds a newSnapAccountService:ensureReady(snapId)messenger action, and exposes config for onboarding gating and Snap-keyring wait timeout.Updates multichain Snap providers to use the new readiness flow.
MultichainAccountServicedrops itsensureCanUseSnapPlatformmethod/action and related config/types, andSnapAccountProvider.ensureCanUseSnapPlatform()is renamed toensureReady()and now callsSnapAccountService:ensureReady. Tests, messenger policies, dependency graph, and package deps/tsconfig references are updated accordingly.Reviewed by Cursor Bugbot for commit c41e954. Bugbot is set up for automated code reviews on this repo. Configure here.