Skip to content

feat(accounts-controller): add new typed options for InternalAccounts #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jul 18, 2025

Explanation

Properly populate entropy options for EVM accounts and also add new typed options for every InternalAccounts.

References

N/A

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly force-pushed the feat/use-keyring-typed-options branch from 9d952f6 to 254e0a5 Compare July 18, 2025 11:34
@ccharly
Copy link
Contributor Author

ccharly commented Jul 21, 2025

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "0.4.0-preview-97b5829f",
  "@metamask-previews/accounts-controller": "31.0.0-preview-97b5829f",
  "@metamask-previews/address-book-controller": "6.1.1-preview-97b5829f",
  "@metamask-previews/announcement-controller": "7.0.3-preview-97b5829f",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-97b5829f",
  "@metamask-previews/approval-controller": "7.1.3-preview-97b5829f",
  "@metamask-previews/assets-controllers": "72.0.0-preview-97b5829f",
  "@metamask-previews/base-controller": "8.0.1-preview-97b5829f",
  "@metamask-previews/bridge-controller": "36.1.0-preview-97b5829f",
  "@metamask-previews/bridge-status-controller": "36.0.0-preview-97b5829f",
  "@metamask-previews/build-utils": "3.0.3-preview-97b5829f",
  "@metamask-previews/chain-agnostic-permission": "1.0.0-preview-97b5829f",
  "@metamask-previews/composable-controller": "11.0.0-preview-97b5829f",
  "@metamask-previews/controller-utils": "11.11.0-preview-97b5829f",
  "@metamask-previews/delegation-controller": "0.5.0-preview-97b5829f",
  "@metamask-previews/earn-controller": "3.0.0-preview-97b5829f",
  "@metamask-previews/eip1193-permission-middleware": "1.0.0-preview-97b5829f",
  "@metamask-previews/ens-controller": "17.0.1-preview-97b5829f",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-97b5829f",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-97b5829f",
  "@metamask-previews/foundryup": "1.0.0-preview-97b5829f",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-97b5829f",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-97b5829f",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-97b5829f",
  "@metamask-previews/keyring-controller": "22.1.0-preview-97b5829f",
  "@metamask-previews/logging-controller": "6.0.4-preview-97b5829f",
  "@metamask-previews/message-manager": "12.0.2-preview-97b5829f",
  "@metamask-previews/messenger": "0.0.0-preview-97b5829f",
  "@metamask-previews/multichain-api-middleware": "1.0.0-preview-97b5829f",
  "@metamask-previews/multichain-network-controller": "0.10.0-preview-97b5829f",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-97b5829f",
  "@metamask-previews/name-controller": "8.0.3-preview-97b5829f",
  "@metamask-previews/network-controller": "24.0.0-preview-97b5829f",
  "@metamask-previews/notification-services-controller": "14.0.0-preview-97b5829f",
  "@metamask-previews/permission-controller": "11.0.6-preview-97b5829f",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-97b5829f",
  "@metamask-previews/phishing-controller": "13.1.0-preview-97b5829f",
  "@metamask-previews/polling-controller": "14.0.0-preview-97b5829f",
  "@metamask-previews/preferences-controller": "18.4.1-preview-97b5829f",
  "@metamask-previews/profile-sync-controller": "21.0.0-preview-97b5829f",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-97b5829f",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-97b5829f",
  "@metamask-previews/sample-controllers": "1.0.0-preview-97b5829f",
  "@metamask-previews/seedless-onboarding-controller": "2.3.0-preview-97b5829f",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-97b5829f",
  "@metamask-previews/signature-controller": "31.0.1-preview-97b5829f",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-97b5829f",
  "@metamask-previews/transaction-controller": "58.1.1-preview-97b5829f",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-97b5829f"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant