Disable default schema validation in UserStorageController #6074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state of things and why does it need to change?
Currently, public
UserStorageController
methods that interact with the storage SDK implicitly enforce schema validation (validateAgainstSchema: true
) without providing an option to override this behavior. This default is not suitable for all scenarios, as some consumers may need to store data that does not conform to a predefined schema or manage schema validation externally.What is the solution your changes offer and how does it work?
This PR updates all relevant public
UserStorageController
methods to setvalidateAgainstSchema: false
by default when calling the underlying storage SDK. This change provides greater flexibility, allowing consumers to store data without mandatory schema validation, aligning with use cases where schema enforcement is not required or handled elsewhere.Are there any changes whose purpose might not obvious to those unfamiliar with the domain?
The
performDeleteStorageAllFeatureEntries
andperformBatchDeleteStorage
methods previously did not include thevalidateAgainstSchema
parameter. This PR adds it with the valuefalse
to ensure consistent behavior across all public storage operations.References
Changelog
Checklist