seedless controller: store encrypted password locally #5988
+129
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgeihs
force-pushed
the
mg/seedless-controller/store-encrypted-password
branch
from
a91643a to
fde625f
Compare
matthiasgeihs
force-pushed
the
mg/seedless-controller/store-encrypted-password
branch
from
fde625f to
d327019
Compare
|
@metamaskbot publish-preview |
matthiasgeihs
changed the title
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthiasgeihs
force-pushed
the
mg/seedless-controller/store-encrypted-password
branch
from
8bb56c8 to
22b6fd0
Compare
lwin-kyaw
reviewed
Jun 16, 2025
| @@ -119,6 +122,10 @@ const seedlessOnboardingMetadata: StateMetadata<SeedlessOnboardingControllerStat | |||
| persist: false, | |||
| anonymous: true, | |||
| }, | |||
| encryptedPassword: { | |||
| persist: true, | |||
There was a problem hiding this comment.
May I know why do we need to persist this?
There was a problem hiding this comment.
because you need it when the keyring vault is locked.
let's say you are locked out of your device.
now you get the message, password changed.
you enter new password.
the seedless controller will fetch the encryption key that was used to encrypt your old password here.
will load the encryptedPassword, decrypt it, and return it.
so now other controller can log the user in.
There was a problem hiding this comment.
Got it. Thanks for the explanation.
|
we should close this PR since we are going with option 6 @matthiasgeihs , i am changing the status of this to draft meanwhile to prevent the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Resolves https://github.com/MetaMask/decisions/pull/85. Implements Option 7.
Stores encrypted password locally instead of writing it to the backup store.
Resolves an audit finding as mentioned in the above referenced ADR.
References
Changelog
Checklist