Skip to content

feat: query only latest page for incoming transactions #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2025

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Jun 13, 2025

Explanation

Query only the latest page of transaction history from the accounts API.

In order to minimise load, improve performance, and better align with the transaction state limit.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review June 14, 2025 19:58
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners June 14, 2025 19:58
OGPoyraz
OGPoyraz previously approved these changes Jun 19, 2025
@matthewwalsh0 matthewwalsh0 force-pushed the feat/incoming-transactions-query-latest-page-only branch from 98ff000 to 08a4995 Compare June 19, 2025 15:11
@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) June 19, 2025 15:11
@matthewwalsh0 matthewwalsh0 requested a review from OGPoyraz June 19, 2025 15:14
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "0.2.0-preview-08a4995",
  "@metamask-previews/accounts-controller": "31.0.0-preview-08a4995",
  "@metamask-previews/address-book-controller": "6.1.0-preview-08a4995",
  "@metamask-previews/announcement-controller": "7.0.3-preview-08a4995",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-08a4995",
  "@metamask-previews/approval-controller": "7.1.3-preview-08a4995",
  "@metamask-previews/assets-controllers": "69.0.0-preview-08a4995",
  "@metamask-previews/base-controller": "8.0.1-preview-08a4995",
  "@metamask-previews/bridge-controller": "33.0.0-preview-08a4995",
  "@metamask-previews/bridge-status-controller": "31.0.0-preview-08a4995",
  "@metamask-previews/build-utils": "3.0.3-preview-08a4995",
  "@metamask-previews/chain-agnostic-permission": "0.8.0-preview-08a4995",
  "@metamask-previews/composable-controller": "11.0.0-preview-08a4995",
  "@metamask-previews/controller-utils": "11.10.0-preview-08a4995",
  "@metamask-previews/delegation-controller": "0.5.0-preview-08a4995",
  "@metamask-previews/earn-controller": "2.0.0-preview-08a4995",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-08a4995",
  "@metamask-previews/ens-controller": "17.0.0-preview-08a4995",
  "@metamask-previews/error-reporting-service": "2.0.0-preview-08a4995",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-08a4995",
  "@metamask-previews/foundryup": "1.0.0-preview-08a4995",
  "@metamask-previews/gas-fee-controller": "24.0.0-preview-08a4995",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-08a4995",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-08a4995",
  "@metamask-previews/keyring-controller": "22.0.2-preview-08a4995",
  "@metamask-previews/logging-controller": "6.0.4-preview-08a4995",
  "@metamask-previews/message-manager": "12.0.1-preview-08a4995",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-08a4995",
  "@metamask-previews/multichain-network-controller": "0.9.0-preview-08a4995",
  "@metamask-previews/multichain-transactions-controller": "3.0.0-preview-08a4995",
  "@metamask-previews/name-controller": "8.0.3-preview-08a4995",
  "@metamask-previews/network-controller": "24.0.0-preview-08a4995",
  "@metamask-previews/notification-services-controller": "12.0.0-preview-08a4995",
  "@metamask-previews/permission-controller": "11.0.6-preview-08a4995",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-08a4995",
  "@metamask-previews/phishing-controller": "12.6.0-preview-08a4995",
  "@metamask-previews/polling-controller": "14.0.0-preview-08a4995",
  "@metamask-previews/preferences-controller": "18.1.0-preview-08a4995",
  "@metamask-previews/profile-sync-controller": "19.0.0-preview-08a4995",
  "@metamask-previews/queued-request-controller": "11.0.0-preview-08a4995",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-08a4995",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-08a4995",
  "@metamask-previews/sample-controllers": "1.0.0-preview-08a4995",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-08a4995",
  "@metamask-previews/selected-network-controller": "23.0.0-preview-08a4995",
  "@metamask-previews/signature-controller": "31.0.0-preview-08a4995",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-08a4995",
  "@metamask-previews/transaction-controller": "58.0.0-preview-08a4995",
  "@metamask-previews/user-operation-controller": "37.0.0-preview-08a4995"
}

Deprecate queryEntireHistory option.
Remove cache usage.
@matthewwalsh0 matthewwalsh0 force-pushed the feat/incoming-transactions-query-latest-page-only branch from 08a4995 to f1cda00 Compare June 20, 2025 09:51
@matthewwalsh0 matthewwalsh0 merged commit bc8c0dd into main Jun 20, 2025
214 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/incoming-transactions-query-latest-page-only branch June 20, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants