-
-
Notifications
You must be signed in to change notification settings - Fork 233
refactor!: drop uncached encryption support #5963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikesposito
wants to merge
17
commits into
main
Choose a base branch
from
mikesposito/refactor/remove-uncached-encryption
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d82ae64
refactor!: drop uncached encryption support
mikesposito 95b41a5
remove commented code
mikesposito cf465ce
update tests
mikesposito 383bed2
fix lint
mikesposito 22ba2d5
update changelog
mikesposito 811d079
make `#useEncryptionKey` sync
mikesposito 27657e3
remove unused vars
mikesposito 307119c
revert eslint threshold changes
mikesposito 62318cc
fix seedless-onboarding-controller tests
mikesposito 5f563b5
update changelogs
mikesposito 86b6397
fix changelog validation
mikesposito f3af65b
remove `CachedEncryptionKey.salt` optionality
mikesposito 6e24cbb
(@mcmire): refactor changelog
mikesposito 13f36eb
fix typo
mikesposito e45dede
Merge branch 'main' into mikesposito/refactor/remove-uncached-encryption
mikesposito 169346d
update changelog
mikesposito f037800
refactor: rename class variable to instance variable
mikesposito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is coverage decreasing?