Extends GasFeePoller to update gas properties for unapproved transaction batches
#5950
Conversation
…a publish batch hook
Co-authored-by: Matthew Walsh <[email protected]>
…:MetaMask/core into feat/add-batch-transaction-approval-type
…-estimate-gas-batch-transaction
…-estimate-gas-batch-transaction
…-estimate-gas-batch-transaction
…s-fee-poller-batch
vinistevam
changed the title
GasFeePoller to update gas properties for unapproved transactionBatchesGasFeePoller to update gas properties for unapproved transaction batches
| requireApproval: false, | ||
| }, | ||
| ); | ||
| const txMeta = { ...txBatchMeta, txParams: { ...params, from } }; |
There was a problem hiding this comment.
Minor, is it confusing to have this and transactionMeta below? Maybe we call this transactionMetaForGasEstimates?
There was a problem hiding this comment.
Great suggestion, done.
| } | ||
|
|
||
| log( | ||
| 'Found unapproved batch transactions', |
There was a problem hiding this comment.
Minor, transaction batches?
| this.#updateTransactionBatch(batch); | ||
| } | ||
|
|
||
| #updateTransactionBatch(batch: TransactionBatchMeta) { |
There was a problem hiding this comment.
Rather than accepting the full state which can lead to race conditions in future, could we accept a callback like we do with updateTransactionInternal so we only update specific properties?
There was a problem hiding this comment.
You are right, changed this function to accept a callback.
| transactionMeta: { | ||
| ...txBatchMeta, | ||
| txParams: { | ||
| ...txBatchMeta.transactions?.[0], |
There was a problem hiding this comment.
I maybe missing the context - why we are estimating only the first transaction?
Shouldn't we estimate all nested transactions and return all gas estimates and then UI calculates them all and show as final network fee estimate?
Explanation
This PR extends the
GasFeePollerto track/update gas properties for unapprovedtransactionBatches.Changes
The GasFeePoller now:
transactionBatchesvia#getUnapprovedTransactionBatches.DefaultGasFeeFlow.transaction-batch-updatedevents with updatedgasFeeEstimates.Updates are applied to the
TransactionBatchMetafor each batch, mirroring the behaviour already in place for single transactions.This enhancement ensures that unapproved transaction batches receive timely gas updates similar to individual transactions, improving consistency across transaction types.
References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/5090
Changelog
Checklist