Skip to content

feat: TEMP - testing moving out snap historical price logic out from snaps #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jun 6, 2025

DO NOT MERGE - this was a test

https://www.loom.com/share/04ed970983194a9c8396bc568289197c

Explanation

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "0.1.1-preview-8e80bb02",
  "@metamask-previews/accounts-controller": "30.0.0-preview-8e80bb02",
  "@metamask-previews/address-book-controller": "6.1.0-preview-8e80bb02",
  "@metamask-previews/announcement-controller": "7.0.3-preview-8e80bb02",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-8e80bb02",
  "@metamask-previews/approval-controller": "7.1.3-preview-8e80bb02",
  "@metamask-previews/assets-controllers": "68.1.0-preview-8e80bb02",
  "@metamask-previews/base-controller": "8.0.1-preview-8e80bb02",
  "@metamask-previews/bridge-controller": "32.1.1-preview-8e80bb02",
  "@metamask-previews/bridge-status-controller": "29.1.0-preview-8e80bb02",
  "@metamask-previews/build-utils": "3.0.3-preview-8e80bb02",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-8e80bb02",
  "@metamask-previews/composable-controller": "11.0.0-preview-8e80bb02",
  "@metamask-previews/controller-utils": "11.10.0-preview-8e80bb02",
  "@metamask-previews/delegation-controller": "0.4.0-preview-8e80bb02",
  "@metamask-previews/earn-controller": "1.1.0-preview-8e80bb02",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-8e80bb02",
  "@metamask-previews/ens-controller": "16.0.0-preview-8e80bb02",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-8e80bb02",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-8e80bb02",
  "@metamask-previews/foundryup": "1.0.0-preview-8e80bb02",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-8e80bb02",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-8e80bb02",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-8e80bb02",
  "@metamask-previews/keyring-controller": "22.0.2-preview-8e80bb02",
  "@metamask-previews/logging-controller": "6.0.4-preview-8e80bb02",
  "@metamask-previews/message-manager": "12.0.1-preview-8e80bb02",
  "@metamask-previews/multichain": "4.1.0-preview-8e80bb02",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-8e80bb02",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-8e80bb02",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-8e80bb02",
  "@metamask-previews/name-controller": "8.0.3-preview-8e80bb02",
  "@metamask-previews/network-controller": "23.6.0-preview-8e80bb02",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-8e80bb02",
  "@metamask-previews/permission-controller": "11.0.6-preview-8e80bb02",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-8e80bb02",
  "@metamask-previews/phishing-controller": "12.6.0-preview-8e80bb02",
  "@metamask-previews/polling-controller": "13.0.0-preview-8e80bb02",
  "@metamask-previews/preferences-controller": "18.1.0-preview-8e80bb02",
  "@metamask-previews/profile-sync-controller": "17.1.0-preview-8e80bb02",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-8e80bb02",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-8e80bb02",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-8e80bb02",
  "@metamask-previews/sample-controllers": "0.1.0-preview-8e80bb02",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-8e80bb02",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-8e80bb02",
  "@metamask-previews/signature-controller": "30.0.0-preview-8e80bb02",
  "@metamask-previews/token-search-discovery-controller": "3.3.0-preview-8e80bb02",
  "@metamask-previews/transaction-controller": "57.3.0-preview-8e80bb02",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-8e80bb02"
}

Comment on lines +661 to +662
// Add assertion similar to snap
assertStruct(response, GetHistoricalPricesResponseStruct);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation total is around 1s.
Do we need such strict validation in our snap or here? This is our own API & we know the shape. Also if the shape was incorrect, it would fail elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant