Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D academy updates innkeep #1776

Merged
merged 12 commits into from
Aug 14, 2024
Merged

D academy updates innkeep #1776

merged 12 commits into from
Aug 14, 2024

Conversation

Innkeeping
Copy link
Contributor

Overview

What features/fixes does this PR include?

Please provide the GitHub issue number

Closes #

Follow up Improvement Ideas

  • please list any improvement/ideas

Implementation

Describe technical (nontrivial / non-obvious) parts of your code

Side effects

Assets

[Include screenshots/videos if it makes reviewing easier.]

Adding a category section for Building on Optimism.  This will include overviews of Optimism as well as in-depth resources for building on Optimism.
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
the-game-web ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2024 0:42am

Added to [Questchains](https://app.questchains.xyz/optimism/building-on-optimism)

Uploaded png for cover in last commit.

Created Category for Building on Optimism
Backend deployment fix for graph
@Innkeeping
Copy link
Contributor Author

@dysbulic I added your docker backend updates to this PR and the test checks are still failing. Not happy with the arg and env instructions.

@dysbulic
Copy link
Member

@dysbulic I added your docker backend updates to this PR and the test checks are still failing. Not happy with the arg and env instructions.

@Innkeeping, that's because you needed to change packages/backend/codegen.ts (like I said). 😸

@Innkeeping
Copy link
Contributor Author

My goldfish told me to.

webp replacement
change png to webp
changing building on op src
the right way
this is the way.
Copy link
Member

@dysbulic dysbulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio.

@dysbulic dysbulic merged commit 91b4eab into develop Aug 14, 2024
21 checks passed
@dysbulic dysbulic deleted the dAcademy-updates-innkeep branch August 14, 2024 01:10
Copy link

Successfully undeployed the Preview of this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants