Fix Chain Ids for QuestChains #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Successfully undeployed the Preview of this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What features/fixes does this PR include?
Downgrades
ethersto v5 for compatibility with Quest Chains.Specifically, when v5's
Provider.isProvider()is called with a v6Provider, it returnsfalse, causing the contract loading to not work correctly.Follow up Improvement Ideas
Quest Chains needs to be updated to
ethersv6 (which was released almost two years ago) because v5 is incompatible with other libraries like the Ethereum Attestation Service.Implementation
Most everything present in v6 was also present in v5, but the import paths are different.
Switched from
BrowserProvidertoWeb3Providerwhich is roughly equivalent.