Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify signup - READY FOR REVIEW #5 #1608

Merged
merged 43 commits into from
Nov 19, 2023
Merged

Unify signup - READY FOR REVIEW #5 #1608

merged 43 commits into from
Nov 19, 2023

Conversation

nitegeist
Copy link
Contributor

@nitegeist nitegeist commented Sep 20, 2023 •
edited
Loading

Overview

What features/fixes does this PR include?
This PR creates a page that unifies the signup of players, guilds and patrons
Please provide the GitHub issue number

Closes #

https://www.notion.so/meta-game/Improving-UX-02ea24e2fdc14cc4be0bebbede3b9487?p=e7842eac487f4e11b3495363133f09a2&pm=s

https://www.notion.so/meta-game/Rotating-1liners-4ab98ad7d7ab4821a8cfff7b0ec94c14

Follow up Improvement Ideas

  • please list any improvement/ideas

Implementation

Describe technical (nontrivial / non-obvious) parts of your code

Side effects

Assets

[Include screenshots/videos if it makes reviewing easier.]

@vercel
Copy link

vercel bot commented Sep 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
the-game-web ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 4:47am

@nitegeist nitegeist self-assigned this Sep 20, 2023
@github-actions github-actions bot temporarily deployed to Test-PR-1608 September 20, 2023 16:12 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1608 September 20, 2023 22:42 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1608 October 2, 2023 19:07 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1608 October 7, 2023 00:00 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1608 October 10, 2023 04:22 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1608 October 11, 2023 01:11 Destroyed
Seroxdesign
Seroxdesign requested changes Oct 11, 2023
View reviewed changes
packages/web/components/Landing/NewOnboard.tsx Outdated Show resolved Hide resolved
packages/web/components/Landing/NewOnboard.tsx Outdated Show resolved Hide resolved
packages/web/components/Landing/NewOnboard.tsx Outdated Show resolved Hide resolved
packages/web/components/Landing/NewOnboard.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to Test-PR-1608 October 12, 2023 00:57 Destroyed
@nitegeist nitegeist changed the title Unify signup Unify signup - READY FOR REVIEW Oct 12, 2023
@nitegeist nitegeist marked this pull request as ready for review October 12, 2023 00:58
@github-actions github-actions bot temporarily deployed to Test-PR-1608 October 12, 2023 01:59 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1608 October 12, 2023 19:04 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1608 November 14, 2023 03:48 Destroyed
@alalonde alalonde merged commit 27832ee into develop Nov 19, 2023
21 checks passed
@alalonde alalonde deleted the nitegeist/unify-signup-pages branch November 19, 2023 05:41
@github-actions GitHub Actions
Copy link

Successfully undeployed the Preview of this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seroxdesign Seroxdesign Seroxdesign approved these changes

@alalonde alalonde alalonde approved these changes

Assignees

@nitegeist nitegeist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitegeist @Seroxdesign @alalonde @peth-yursick