Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made a couple small tweaks to the ComposeDB profile model #1592

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Made a couple small tweaks to the ComposeDB profile model #1592

merged 3 commits into from
Sep 20, 2023

Conversation

alalonde
Copy link
Contributor

Overview

Closes #1589

Follow up Improvement Ideas

Once this gets merged, I'll need to deploy the model to our production node as well

@vercel
Copy link

vercel bot commented Aug 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
the-game-web ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 3:59pm

@alalonde alalonde requested a review from dysbulic August 11, 2023 03:53
@github-actions github-actions bot temporarily deployed to Test-PR-1592 August 25, 2023 05:48 Destroyed
Seroxdesign
Seroxdesign approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@Seroxdesign Seroxdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again not sure what this does, but LGTM

dysbulic
dysbulic requested changes Aug 30, 2023
View reviewed changes
Copy link
Member

@dysbulic dysbulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These still don't look quite right to me. Also, can someone be colorless on the five-color disposition, so the minLength would be zero?

(Sorry for taking so long. Clearing headspace to review properly has been a challenge.)

packages/utils/schema/user-profile.graphql Outdated Show resolved Hide resolved
packages/utils/schema/user-profile.graphql Outdated Show resolved Hide resolved
@alalonde
Copy link
Contributor Author

These still don't look quite right to me. Also, can someone be colorless on the five-color disposition, so the minLength would be zero?

I removed the minLength requirement

dysbulic
dysbulic approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@dysbulic dysbulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dysbulic dysbulic merged commit f100761 into develop Sep 20, 2023
20 checks passed
@dysbulic dysbulic deleted the composedb-model-1 branch September 20, 2023 17:00
@github-actions
Copy link

Successfully undeployed the Preview of this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seroxdesign Seroxdesign Seroxdesign approved these changes

@dysbulic dysbulic dysbulic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take ComposeDB from testing to production
3 participants
@alalonde @dysbulic @Seroxdesign