Improve MegaMenu - Ready For Review #1571
Conversation
|
This is ready for review @alalonde |
|
TODO: Switch the breakpoints to 1600 for desktop |
There was a problem hiding this comment.
I was going to comment on this in the Discord, but was too late, sorry.
Changing the value for the breakpoints here is going to affect other things in the site that were using them for the layouts. I know I did some work on designs that depended on the xl breakpoint being 80em.
If the changes to the breakpoints are to work only for the MegaMenu, would it work to write some custom css just for that component?
There was a problem hiding this comment.
Changing breakpoints was recommended by @dysbulic, I believe I tested a few pages out here so I'm not sure we will have any breaking issues.
Although i did as much changes to actual component as I could without going out of the design provided to me.
Open to changing it if I need to but would rather not
There was a problem hiding this comment.
I agree, we probably don't want to change the breakpoints for the entire site. Can you just override them for the MegaMenu ?
There was a problem hiding this comment.
I'll look into it
There was a problem hiding this comment.
I'd be happy to compare the design with what we're seeing in the deploy, but I think I need a Linear.app invite.
for e.g. it looks like the MG logo has dropped out, but not sure if that's on purpose.
Here's the current site 👇
On this deploy I'm not seeing that logo 👇
There was a problem hiding this comment.
Good catch, I'll get that fixed soon
There was a problem hiding this comment.
logo is back, check with Peth in builders-guild for access to linear
|
Successfully undeployed the Preview of this Pull Request |
Overview
What features/fixes does this PR include?
This improves the mega-menu to showcase more links to users without having to expand the menus
Please provide the GitHub issue number
https://linear.app/metagame/issue/MG-17/clean-up-the-mega-menu-by-merging-or-removing-more-stuff
Closes #
Follow up Improvement Ideas
Implementation
Describe technical (nontrivial / non-obvious) parts of your code
Side effects
Assets
[Include screenshots/videos if it makes reviewing easier.]