Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What We Do #1570

Merged
merged 16 commits into from
Jul 18, 2023
Merged

What We Do #1570

merged 16 commits into from
Jul 18, 2023

Conversation

Seroxdesign
Copy link
Contributor

@Seroxdesign Seroxdesign commented Jun 8, 2023

Overview

What features/fixes does this PR include?

This adds a section "who are we" to the MG landing page and it showcases players, elders, patrons and guilds

Please provide the GitHub issue number

https://linear.app/metagame/issue/MG-13/add-players-guilds-patrons-and-advisors-section

Closes #

Follow up Improvement Ideas

  • please list any improvement/ideas

Implementation

Describe technical (nontrivial / non-obvious) parts of your code

Side effects

Assets

[Include screenshots/videos if it makes reviewing easier.]

@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 8, 2023 09:55 Destroyed
@Seroxdesign Seroxdesign changed the title who we are section, small component for user grid What We Do Jun 9, 2023
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 9, 2023 15:27 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 13, 2023 09:54 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 14, 2023 11:53 Destroyed
@Seroxdesign Seroxdesign marked this pull request as ready for review June 20, 2023 15:26
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 20, 2023 15:57 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 21, 2023 08:10 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 22, 2023 15:55 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 23, 2023 10:16 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1570 June 28, 2023 15:44 Destroyed
Copy link
Contributor

@alalonde alalonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides a couple of minor issues. Needs a rebase too

packages/web/components/Landing/WhoAreWe.tsx Outdated Show resolved Hide resolved
packages/web/components/Player/PlayerProfilePicture.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to Test-PR-1570 July 3, 2023 10:41 Destroyed
@Seroxdesign
Copy link
Contributor Author

@alalonde resolved requested changes, should be good now

@alalonde
Copy link
Contributor

alalonde commented Jul 6, 2023

All the pbs.twimg.com images seem to be broken for me in the deployment..

@github-actions github-actions bot temporarily deployed to Test-PR-1570 July 6, 2023 15:53 Destroyed
@alalonde
Copy link
Contributor

alalonde commented Jul 6, 2023

Also, the "subscribe" input field at the bottom is not usable

@Seroxdesign
Copy link
Contributor Author

Also, the "subscribe" input field at the bottom is not usable

what page & button is this? I just merged in dev to who-we-are so let's give it a few before testing again

@alalonde
Copy link
Contributor

alalonde commented Jul 6, 2023

Landing page

@Seroxdesign
Copy link
Contributor Author

@alalonde
image

working for me

@Seroxdesign
Copy link
Contributor Author

@alalonde can we get this merged?

@alalonde
Copy link
Contributor

Yes, I cannot click on the "subscribe" input field on Brave or FF macos. However the same issue is in test, so we can address elsewhere.

@alalonde alalonde merged commit 174f38c into develop Jul 18, 2023
@alalonde alalonde deleted the sero/what-we-do branch July 18, 2023 17:48
@github-actions
Copy link

Successfully undeployed the Preview of this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants